Repository navigation
feat(interactive_browser): tag provider sessions with the episode - #3932
Merged
Merged
Conversation
A provider session was tagged with the resources_session_id only. Under an Environment Server that id is minted inside the Environment Server and never reaches the training record, so it could not join a leaked cloud session back to its rollout. - A typed seed passes the episode's rollout_id and attempt to the backend as session metadata, next to the existing session id. - remote_cdp logs the provider's session id together with that metadata when it acquires a session, and includes the metadata when a release fails. A provider that ignores metadata still gets the join in the environment's own log. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: waple0820 <232305951+waple0820@users.noreply.github.com>
nemo-automation-bot
Bot
added
the
community-request
yaoyu-33
added
area:environment
ananthsub
approved these changes
Oct 2, 2026
Contributor
|
/ok to test 190df88 |
Contributor
|
🌿 Preview your docs: https://nvidia-preview-pr-3932-190df8896363.docs.buildwithfern.com/nemo/gym |
Contributor
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA-NeMo/Gym/actions/runs/37035131806 |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Small follow-up to #3812. A browser seeded by an Environment Server now carries its episode (
rollout_id,attempt) to the session provider, andremote_cdplogs the provider's session id together with it when the session is acquired.Why
Provider sessions were tagged with
resources_session_idonly. Under an Environment Server that id is minted insidesingle_agent_turnand never reaches the episode result, so it can't join a leaked cloud session back to the rollout that held it. The episode id is on both sides: it comes in with the seed and goes out on the result.The log line covers providers that ignore metadata: the join still exists in the environment's own log.
Changes
rollout_idandattemptto the backend's session metadata. Legacy/runseeds are unchanged (no episode to tag).remote_cdplogsProvider 'x' session <id> acquired for {...}on acquire, and includes the metadata in the release-failure warning.Tests
Three new tests, failing before the change: typed seed passes the episode in metadata, legacy seed doesn't, and the acquire log line names both the provider session and the rollout.
🤖 Generated with Claude Code